Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a PHP8 support #53

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Adds a PHP8 support #53

merged 7 commits into from
Sep 26, 2022

Conversation

BOPOH
Copy link
Contributor

@BOPOH BOPOH commented Sep 26, 2022

No description provided.

@gigorok
Copy link
Member

gigorok commented Sep 26, 2022

@BOPOH thanks. Please add the required PHP versions (8.0, 8.1) to gh workflows. here https://github.com/didww/didww-api-3-php-sdk/blob/master/.github/workflows/tests.yml#L13

@BOPOH
Copy link
Contributor Author

BOPOH commented Sep 26, 2022

Sorry, there is an error for PHP8.0. The reason is composer.lock. Should I force to use packages working for 8.0?
May be deleting of composer.lock is the best way?

@gigorok
Copy link
Member

gigorok commented Sep 26, 2022

Sorry, there is an error for PHP8.0. The reason is composer.lock. Should I force to use packages working for 8.0? May be deleting of composer.lock is the best way?

Yep. Looks like composer.lock should be removed from the repo. Please remove it

@gigorok gigorok merged commit 5c684e2 into didww:master Sep 26, 2022
@gigorok
Copy link
Member

gigorok commented Sep 26, 2022

@BOPOH thanks for your help! 👍

@BOPOH BOPOH mentioned this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants